TypeError ("string indices must be integers, not 'str'",)

[varac]

I'm using v0.5.0 of this hook, but I get this error:

[ERROR] vaultwarden-hr.yaml: TypeError ("string indices must be integers, not 'str'",)

vaultwarden-hr.yaml:

---
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: vaultwarden
  namespace: vaultwarden
spec:
  releaseName: vaultwarden
  chartRef:
    kind: OCIRepository
    name: vaultwarden
    namespace: flux-system
  interval: "24h"

vaultwarden-oci-repo.yaml:

---
apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: OCIRepository
metadata:
  name: vaultwarden
  namespace: flux-system
spec:
  interval: 1h
  url: oci://tccr.io/truecharts/vaultwarden
  layerSelector:
    mediaType: "application/vnd.cncf.helm.chart.content.v1.tar+gzip"
    operation: copy
  ref:
    semver: "28.3.3"

[tarioch]

@jamiezieziula can you have a look?

[LEI]

Also seeing this error with helm.toolkit.fluxcd.io/v2 only on a kube-prometheus-stack release and a custom values file of another chart.

[kadaan]

@tarioch @jamiezieziula Isn't this the typo int he code that is causing this issue? https://github.com/tarioch/flux-check-hook/blame/5cf8216341e96cd5594f6bce1a53f0942b72e0ac/pre_commit_flux/check_flux_helm_values.py#L59

definition["spec"["chartRef"]]

[tarioch]

thank you very much, I think that makes sense, adjusted. Can someone verify?

[varac]

I re-enabled the hook, made a test commit and it seems to work. Thank you !