dune-release icon indicating copy to clipboard operation
dune-release copied to clipboard

Confusing error message if no web browser is installed

Open mato opened this issue 4 years ago • 1 comments

I'm running dune-release on a machine with no web browser installed. When doing the opam submit step, I get:

[?] Open PR to ocaml/opam-repository? [Y/n]

[-] Opening pull request to merge branch release-mirage-solo5-0.6.4 of [email protected]:mato/opam-repository into ocaml/opam-repository
/usr/bin/xdg-open: 870: /usr/bin/xdg-open: www-browser: not found
/usr/bin/xdg-open: 870: /usr/bin/xdg-open: links2: not found
/usr/bin/xdg-open: 870: /usr/bin/xdg-open: elinks: not found
/usr/bin/xdg-open: 870: /usr/bin/xdg-open: links: not found
/usr/bin/xdg-open: 870: /usr/bin/xdg-open: lynx: not found
/usr/bin/xdg-open: 870: /usr/bin/xdg-open: w3m: not found
xdg-open: no method available for opening 'https://github.com/ocaml/opam-repository/pull/17517'
[+] A new pull-request has been created at https://github.com/ocaml/opam-repository/pull/17517

This is confusing, since it looked like something went wrong, when in fact all that happened is that dune couldn't show the PR in a browser. I suggest just printing an URL to click on (since I was SSH-ing into the machine in question, that'll work).

mato avatar Oct 27 '20 15:10 mato

Indeed those extra lines are confusing, capturing xdg-open's output here should do the trick since the last line of logs from dune-release:

[+] A new pull-request has been created at https://github.com/ocaml/opam-repository/pull/17517

should make it clear everything went smoothly!

Thanks for reporting this!

NathanReb avatar Oct 27 '20 15:10 NathanReb