dune-release icon indicating copy to clipboard operation
dune-release copied to clipboard

Remove the bistro command

Open gpetiot opened this issue 5 years ago • 3 comments

Calling dune-release without a sub-command is the same as calling dune-release bistro. Is there really a benefit to having this command? (not sure this is even properly documented)

gpetiot avatar Jun 24 '20 15:06 gpetiot

Maybe a better suited name would do the trick, something like dune-release auto or dune-release all.

Adding documentation and stating that it's the default command seems good enough but I think it's already the case for bistro

We can't remove it without doing a major release but if we wish to improve the doc and eventually add an alias we can do that already! We could then deprecate it and finally drop it when releasing 2.0!

NathanReb avatar Jun 24 '20 16:06 NathanReb

@NathanReb Should we move this for the 2.0.0 milestone? I fear that given we already started, it is a bit late to remove but we could at least deprecate it.

Leonidas-from-XIV avatar Sep 24 '21 10:09 Leonidas-from-XIV

I think it's fine to remove it in 2.0 without warning. Not best practice but I doubt anybody has a script that runs dune-release bistro so it's unlikely to break anything serious, and I doubt anyone would bother typing dune-release bistro when it's the same as dune-release.

NathanReb avatar Sep 27 '21 12:09 NathanReb