dune-release icon indicating copy to clipboard operation
dune-release copied to clipboard

dune-release publish fails with non-github homepage

Open avsm opened this issue 5 years ago • 3 comments

With cppo, homepage is "mjambon.com/cppo.html" and the publish release action gets a 404 from github as it infers a wrong url

dune-release: [EXEC:62459] ['curl' '-L' '-s' '-S' '-K' '-' '-D' '-' '--data'
                            '{ "tag_name" : "v1.6.6", "body" : "CHANGES:\n\n- [pkg] port build system to dune from jbuilder.\n- [pkg] upgrade opam metadata to 2.0 format.\n- [pkg] remove topkg and use dune-release.\n- [compat] Use `String.capitalize_ascii` to remove warning.\n" }'
                            'https://api.github.com/repos/cppo.html/releases/releases']
dune-release: [ERROR] Could not find release id in response:
                      HTTP/1.1 404 Not Found
                      Server: GitHub.com

avsm avatar May 26 '19 23:05 avsm

Thanks for reporting this! I'll have a look, should be fairly easy to fix!

NathanReb avatar May 27 '19 14:05 NathanReb

I can't reproduce this with the latest dune-release on a dummy package with a custom homepage field and as I don't have right access to cppo ,dune-release publish distrib fails too early to reproduce the error.

I'll try to reproduce it somehow but in the meantime, do you know which dune-release version you were using?

NathanReb avatar May 27 '19 18:05 NathanReb

I figured it out, I'll try and fix it but the whole parsing code is scattered across various different places and I'd like to find a proper solution to this problem rather than just squeeze a fragile fix in and make the whole situation worse.

NathanReb avatar May 27 '19 19:05 NathanReb