dune-release icon indicating copy to clipboard operation
dune-release copied to clipboard

Distrib on broken tags fails and can't roll back

Open Leonidas-from-XIV opened this issue 7 years ago • 2 comments

When you dune-release tag a new git tag is created, but there is no validation that said tag actually works. So when doing dune-release distrib afterwards this might fail (because the build fails or tests fail etc) so now you have a tag that is invalid and needs to be removed manually.

I am aware that distrib needs a version to construct the tarball but the ordering is unfortunate. Maybe there could be something like attempt-tag or similar that could abort when it can't create a tarball.

Leonidas-from-XIV avatar Oct 18 '18 09:10 Leonidas-from-XIV

You can use dune-release tag -d to remove the tag. That works fairly well since at that point the tag only exists locally.

I agree it is unfortunate though, we might consider offering to delete the tag ourselves if distrib fails!

NathanReb avatar Nov 22 '19 13:11 NathanReb

Also note that you can run distrib without tagging, you should only get a warning!

NathanReb avatar Nov 22 '19 13:11 NathanReb