Michaël Zasso

Results 1686 comments of Michaël Zasso

The build still looks broken.

``` 2024-09-01T01:43:13.3207023Z sccache clang++ -o /home/runner/work/node/node/out/Release/node_mksnapshot -pthread -rdynamic -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib.a -Wl,--no-whole-archive -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/deps/uv/libuv.a -Wl,--no-whole-archive -Wl,-z,noexecstack -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_snapshot.a -Wl,--no-whole-archive -Wl,-z,relro -Wl,-z,now -Wl,--whole-archive,/home/runner/work/node/node/out/Release/obj.target/deps/openssl/libopenssl.a -Wl,--no-whole-archive -pthread -m64 -Wl,--start-group /home/runner/work/node/node/out/Release/obj.target/node_mksnapshot/src/node_snapshot_stub.o /home/runner/work/node/node/out/Release/obj.target/node_mksnapshot/tools/snapshot/node_mksnapshot.o /home/runner/work/node/node/out/Release/obj.target/libnode.a /home/runner/work/node/node/out/Release/obj.target/deps/histogram/libhistogram.a /home/runner/work/node/node/out/Release/obj.target/deps/sqlite/libsqlite.a...

Let's try to recreate from scratch

https://github.com/nodejs/node/pull/54713

I manually synced the assets after seeing that they were not on R2

I don't know if the upload script was called, but it isn't commented out in `_promote.sh`: ![CleanShot 2023-11-15 at 14 49 02](https://github.com/nodejs/release-cloudflare-worker/assets/2352663/68571565-3a62-4018-86c8-21202eb2a643)

I'm not sure it's related to people accessing the server directly. When there's a new release, we just have a lot of load coming from Cloudflare servers. One solution might...

I agree with @aduh95 but I don't think this section of the license is relevant. Corepack doesn't include or distribute npm's source code.

Blocked on https://github.com/nodejs/node/issues/52682