Michaël Zasso

Results 1686 comments of Michaël Zasso

Commit: ef4184cbd6db1afbab5127577264505c799c8625 CI: https://ci.nodejs.org/job/node-test-commit/56400/ V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4857/

Commit: d3cfc1168917c46374209fa51695b3c0287e42b9 CI: https://ci.nodejs.org/job/node-test-commit/56659/ V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4875/

I tried to enable it, but quickly reverted the change, because: > Only users with admin or maintain permissions in the repository will be able to create protected tags, and...

Unfortunately, I don't think we have access to custom repository roles. At least I can't find the option in the org settings.

It seems to be a feature specific to "Enterprise Cloud" GitHub.

For example, one of the errors: ``` node:assert:124 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: null !== 0 at Object. (/home/runner/work/node-v8/node-v8/test/parallel/test-snapshot-warning.js:40:12) at Module._compile (node:internal/modules/cjs/loader:1119:14) at...

> Do I simply need to build the canary branch from this repo? Yes

Thanks for opening this. It also affect V8 10.3: https://github.com/nodejs/node/pull/43195#issuecomment-1135775636

Example in CI: https://ci.nodejs.org/job/node-test-commit-arm-debug/2497/nodes=ubuntu1804-arm64/ Problematic code: https://github.com/nodejs/node/blob/6ac55fa337b57cecf36602d0acc3da25ee82a589/src/env-inl.h#L222-L237 /cc @nodejs/async_hooks

@santigimeno you can open a PR on [nodejs/node](https://github.com/nodejs/node/pulls), targeting the [`canary-base`](https://github.com/nodejs/node/tree/canary-base) branch (I just made it have the same HEAD as canary in this repo).