Michaël Zasso
Michaël Zasso
``` gyp ERR! configure error gyp ERR! stack TypeError: isInsideNodeModules is not a function gyp ERR! stack at urlParse (node:url:126:27) gyp ERR! stack at Object.urlResolve [as resolve] (node:url:717:10) ```
Are https://chromium-review.googlesource.com/c/v8/v8/+/4403395 and https://chromium-review.googlesource.com/c/v8/v8/+/4405689 necessary for this to work?
I checked out the PR, rebased it and fixed the linter issues but for some reason I'm unable to push it back: ``` $ git push [email protected]:dinfuehr/node di/do-not-drain-worker-tasks -f ERROR:...
@aduh95 Thanks! Now I'm curious: how did you do it?
Still happening. Looking at https://github.com/nodejs/node-v8/actions/workflows/test-linux.yml: - Oct 27 (V8 14.3.127) and earlier were OK - Oct 28 (V8 14.4.7) first failure: https://github.com/v8/v8/compare/14.3.127...14.4.7 - Oct 29 (V8 14.4.13) back to OK:...
I suspect https://github.com/v8/v8/commit/db44401fef4522abdc2430652d9c602b6e45baf7 It was relanded on Oct 28, reverted on Oct 29, and relanded again on Oct 30.
Still failing: https://github.com/nodejs/node-v8/actions/runs/19816998138/job/56770380628
I bisected it to https://chromium-review.googlesource.com/c/v8/v8/+/7139418
It's more complex than this. If I revert that commit on the V8 14.4 update branch, the test still fails.
> I noticed that the debug build has been failing on canary, this gyp change should fix it: https://github.com/joyeecheung/node/tree/fix-debug - where should I submit this? You can directly cherry-pick and...