Michaël Zasso

Results 1686 comments of Michaël Zasso

We also encounter https://github.com/nodejs/node-v8/issues/304 And another error with shared libraries, maybe related to GCC.

Ah, I forgot about this one. The change should really be upstreamed. It was lost because I always take the canary branch as a reference for V8 updates.

Still failing with gcc 14: ``` In file included from ../../deps/v8/src/runtime/runtime.h:14, from ../../deps/v8/src/codegen/external-reference.h:9, from ../../deps/v8/src/codegen/external-reference-table.h:11, from ../../deps/v8/src/execution/isolate-data.h:10, from ../../deps/v8/src/execution/isolate.h:33, from ../../deps/v8/src/api/api.h:18, from ../../deps/v8/src/api/api.cc:5: ../../deps/v8/src/strings/unicode.h:218:13: error: explicit specialization in non-namespace scope...

About https://github.com/nodejs/node/pull/61002#issuecomment-3631137188 I'm not used to debugging V8. If I try to print the name and value of the property being added at frame 21, I get this: ``` (lldb)...

I'll cherry-pick https://chromium-review.googlesource.com/c/v8/v8/+/7252791 when it's landed.

We also need a test that tries to load an unexpected file (that is not a sqlite extension). It should throw, not crash the process.

Showing that the object is proxied SGTM. We could also print the names of the proxy traps that are defined.

@jasnell I don't think what you wrote is correct. `env.h` only declares `Environment` to use it as a pointer. We don't expose `env.h` in the public headers. https://github.com/nodejs/node/blob/20c4b80ffca2738046b21f5792e239ccfa8c9321/src/node.h#L231

Can you post a couple examples ?

It's not clear to me that there are legitimate native addons in the search result. I only see Node.js source code and Electron source code.