Michaël Zasso

Results 1686 comments of Michaël Zasso

I gave him access, with the "Viewer" role (initially tried what was in the OP but it wasn't enough).

Unfortunately I don't have the time to learn the GitHub API. A quick glance at https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#create-a-pull-request seems to suggest you cannot add assignee while creating a PR.

Yes, it's in `gh pr create`, but the script was changed in https://github.com/nodejs/node/pull/56054 to use `gh api` instead!

I haven't looked at it

I don't know how to reliably detect what is the maximum size for a typed array. Since Node.js 22, there is no arbitrary limit in V8. On macOS, what I...

I'm not sure the js heap size is relevant. ArrayBuffer data are notably not counted in it.

And in browsers, the typed array size limit is unrelated to the memory limit. It's arbitrarily chosen by the browser.

Commit: https://github.com/nodejs/node-v8/commit/30329d06235a9f9733b1d4da479b403462d1b326 CI: https://ci.nodejs.org/job/node-test-commit/71329/ V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/6020/

V8 CI is broken: https://ci.nodejs.org/job/node-test-commit-v8-linux/6020/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console ``` 13:29:56 + PATH=/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools:/home/iojs/build/workspace/node-test-commit-v8-linux/depot_tools:/home/iojs/venv/bin:/home/iojs/nghttp2/src:/home/iojs/wrk:/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin tools/dev/v8gen.py x64.release --no-goma 13:29:56 usage: v8gen.py [-h] {gen,list} ... 13:29:56 v8gen.py: error: unrecognized arguments: --no-goma ``` https://github.com/v8/v8/commit/6c5a6c03dd6f557fcdf550ae3a2c66ed66d805ce I opened [a PR](https://github.com/nodejs/node/pull/53336)...

Commit: https://github.com/nodejs/node-v8/commit/4bbb10abe6f1469950710066c044900ef4727fff CI: https://ci.nodejs.org/job/node-test-commit/81778/ V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/6686/