strelka icon indicating copy to clipboard operation
strelka copied to clipboard

Adding Google Magika Tastes

Open phutelmyer opened this issue 1 year ago • 1 comments

Describe the change This change is still in draft, but the idea was to add another form of file tasting: Google Magika

Describe testing procedures Built and tested against files - no known issues with file tasting outside perhaps misattribution (no errors)

The only error comes with import "magic" inside taste.yara and any yara that uses magic. A conflict?

Sample output

{
  "magika": [
    "iso"
  ],
  "mime": [
    "application/octet-stream"
  ],
  "yara": [
    "onenote_file"
  ]
}

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of and tested my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings

phutelmyer avatar Feb 16 '24 18:02 phutelmyer

@skalupa Do we feel as if we should keep this PR open? Seems like magika is still under some solid development, but there is always at least some value in additional tasting engine where YARA or MIME fails.

phutelmyer avatar Feb 25 '25 12:02 phutelmyer