Lorri sets `$out`

Open nomeata opened this issue 5 years ago • 1 comments

I just noticed that lorry sets $out:

~/foo $ echo $out
/nix/store/s7zha1rssggdnvasm6mjnknrd8042kaa-lorri-wrapped-project-nix-shell

I noticed because I wanted to embed $out in a program as a source identifier when built with nix-build (because git describe is unavailable there), and found it odd that this set via lorri.

If it serves no purposes, might just be nice and clean to omit it, if possible.

Jun 20 '20 15:06 nomeata

There is a test which contains all the variables that are expected to be set, and out is one of them: https://github.com/target/lorri/blob/4214b78a91a9d2149ea435c6d1e976da572bad58/tests/integration/bug97_varmap_leak.rs#L21

This was introduced in https://github.com/target/lorri/commit/a1104eafba6d6110d1c60b5f4e583f3d6daea963#diff-078e54cefa85d7c7cca1042dcd69a838R14. @grahamc, you added this test -- would you mind taking a look at @nomeata's question here?

Jun 22 '20 08:06 curiousleo