tardis icon indicating copy to clipboard operation
tardis copied to clipboard

[GSOC] Benchmark for read_stella_model function using asv (objective 1 for TARDIS Benchmarking and Performance Improvement)

Open officialasishkumar opened this issue 11 months ago • 6 comments

:pencil: Description

Added a benchmark for read_stella_model function using airspeed velocity.

image

:pushpin: Resources

https://tardis-sn.github.io/summer_of_code/ideas/

:vertical_traffic_light: Testing

How did you test these changes?

  • [ ] Testing pipeline
  • [ ] Other method (describe)
  • [ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

  • [x] I requested two reviewers for this pull request
  • [ ] I updated the documentation according to my changes
  • [ ] I built the documentation by applying the build_docs label

cc: @atharva-2001 @andrewfullard @AlexHls

officialasishkumar avatar Mar 13 '24 06:03 officialasishkumar

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

tardis-bot avatar Mar 13 '24 06:03 tardis-bot

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

tardis-bot avatar Mar 13 '24 06:03 tardis-bot

Good work! Please refer to this PR in your application.

andrewfullard avatar Mar 13 '24 16:03 andrewfullard

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.17%. Comparing base (39c128a) to head (e14936a). Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2548      +/-   ##
==========================================
- Coverage   68.73%   68.17%   -0.57%     
==========================================
  Files         165      166       +1     
  Lines       14001    14135     +134     
==========================================
+ Hits         9624     9636      +12     
- Misses       4377     4499     +122     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 13 '24 16:03 codecov[bot]

What command did you run to produce the asv web output? How long did it take to run the benchmark? Why did you choose the number of commits that are shown in the plot?

andrewfullard avatar Mar 14 '24 14:03 andrewfullard

What command did you run to produce the asv web output?

asv run v3.0.dev4019..master
asv publish
asv preview

How long did it take to run the benchmark?

Around 30 minutes.

Why did you choose the number of commits that are shown in the plot?

I wanted to see the entire timeline since the dawn of read_stella_model.

officialasishkumar avatar Mar 14 '24 16:03 officialasishkumar