tardis icon indicating copy to clipboard operation
tardis copied to clipboard

Published 20 hours ago • verified publisher icon tardis-sn

Convergence plot correction

Open jamesgillanders opened this issue 1 year ago • 3 comments

Describe the bug In the convergence plot widget, both T and W are plotted against shell velocity. These plots should present their data as a step function, instead of a scatter line, since the T and W values are constant throughout each individual shell.

To Reproduce Run the convergence plot.

jamesgillanders avatar Feb 13 '24 12:02 jamesgillanders

Sir, I'm willing to work on this issue with your permission.

Vivek-Joshi17 avatar Feb 25 '24 17:02 Vivek-Joshi17

Go for it!

On 25 Feb 2024, at 17:59, Vivek Joshi @.***> wrote:

Sir, I'm willing to work on this issue with your permission.

— Reply to this email directly, view it on GitHubhttps://github.com/tardis-sn/tardis/issues/2519#issuecomment-1963014134, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALJQVQVKV373A5CE5OX34KTYVN3XLAVCNFSM6AAAAABDGO34N6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTGAYTIMJTGQ. You are receiving this because you authored the thread.Message ID: @.***>

jamesgillanders avatar Feb 25 '24 18:02 jamesgillanders

@jamesgillanders Since this issue was pending since weeks, I have taken the liberty to fix it. PR containing fix. Please review, thanks in advance!

sarthak-dv avatar Mar 04 '24 06:03 sarthak-dv