tardis icon indicating copy to clipboard operation
tardis copied to clipboard

Time_of_simulation for j_blues and continuum process rates is from the wrong iteration

Open chvogl opened this issue 1 year ago • 0 comments

Describe the bug The time of simulation in the plasma seems to be the value for the next iteration. However, the value from the previous iteration (in which the estimators were recorded) should be used to calculate j_blues and continuum process rates (like gamma, alpha_stim) from the estimators. In the case of the continuum estimators, the time of simulation is also not updated in the plasma since t_inner is not included in the update_properties. https://github.com/tardis-sn/tardis/blob/87e8f3a8b6fd7fc0caf1d03698841f231f688735/tardis/simulation/base.py#L370

To Reproduce Run the code with a variable T_inner (and therefore time of simulation) and either the detailed radiation field treatment or continuum processes enabled.

chvogl avatar Nov 10 '23 11:11 chvogl