tardis icon indicating copy to clipboard operation
tardis copied to clipboard

Published 20 hours ago • verified publisher icon tardis-sn

Montecarlo Packet Progress bar does not go to 100%

Open Rodot- opened this issue 2 years ago • 5 comments

Describe the bug When running the montecarlo main loop, the progress bar updates with an approximation for the number of packets completed when run in multithreaded mode. At the end of the loop, the progress bar is no longer updated so the display never shows it reaching 100%.

To solve this problem, at the end of the loop another update call to the progress bar should be made to fill out the remaining progress.

To Reproduce Run a tardis model with >=2 threads

System

  • OS:

    • [x] GNU/Linux
    • [x] macOS

  • Environment (conda list):

Additional context

Rodot- avatar Feb 21 '23 15:02 Rodot-

@Rodot- Are you still working on this? If not, can I pick it up?

AyushiDaksh avatar Feb 28 '23 13:02 AyushiDaksh

I'm not working on this myself so it is definitely up for grabs

Rodot- avatar Feb 28 '23 14:02 Rodot-

@Rodot- There seems to be a delay of a few seconds (even after the particular cell in the notebook has finished running), after which the packet progress bar does update to 100%. I could reproduce this for 1 <= no. of threads <= 4.

shreyas3156 avatar Mar 06 '23 18:03 shreyas3156

Hi @Rodot- I have made a PR that aims to solve this issue. It would be great if you could review it.

shreyas3156 avatar Mar 09 '23 18:03 shreyas3156

@Rodot- Does PR https://github.com/tardis-sn/tardis/pull/2237 fix this issue?

atharva-2001 avatar Mar 21 '23 12:03 atharva-2001