tardis icon indicating copy to clipboard operation
tardis copied to clipboard

Non-LTE Rate Equation Solver

Open sonachitchyan opened this issue 2 years ago • 1 comments

:pencil: Description

Type: :beetle: bugfix | :rocket: feature | :biohazard: breaking change | :vertical_traffic_light: testing | :memo: documentation | :roller_coaster: infrastructure

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

  • [ ] Testing pipeline
  • [ ] Other method (describe)
  • [ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

  • [ ] I requested two reviewers for this pull request
  • [ ] I updated the documentation according to my changes
  • [ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

sonachitchyan avatar Jul 13 '22 20:07 sonachitchyan

Codecov Report

Merging #2090 (9802490) into master (e01e44a) will increase coverage by 3.76%. The diff coverage is 94.87%.

:exclamation: Current head 9802490 differs from pull request most recent head 9b9c816. Consider uploading reports for the commit 9b9c816 to get more accurate results

@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
+ Coverage   58.13%   61.90%   +3.76%     
==========================================
  Files          75       75              
  Lines        8602     8734     +132     
==========================================
+ Hits         5001     5407     +406     
+ Misses       3601     3327     -274     
Impacted Files Coverage Δ
tardis/plasma/properties/nlte.py 68.91% <94.82%> (+28.35%) :arrow_up:
tardis/plasma/properties/property_collections.py 100.00% <100.00%> (ø)
...dis/montecarlo/montecarlo_numba/numba_interface.py 33.84% <0.00%> (-0.80%) :arrow_down:
...dis/montecarlo/montecarlo_numba/formal_integral.py 53.87% <0.00%> (ø)
tardis/simulation/base.py 83.85% <0.00%> (+0.22%) :arrow_up:
tardis/montecarlo/montecarlo_numba/interaction.py 28.36% <0.00%> (+0.36%) :arrow_up:
tardis/montecarlo/montecarlo_numba/base.py 31.35% <0.00%> (+0.84%) :arrow_up:
tardis/io/logger/logger.py 75.86% <0.00%> (+5.17%) :arrow_up:
tardis/montecarlo/montecarlo_numba/r_packet.py 61.53% <0.00%> (+11.53%) :arrow_up:
tardis/visualization/widgets/custom_abundance.py 59.53% <0.00%> (+42.96%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 14 '22 21:07 codecov[bot]

@sonachitchyan I guess we can close this?

chvogl avatar Feb 27 '23 17:02 chvogl