tardis icon indicating copy to clipboard operation
tardis copied to clipboard

Adding nonhomologous grid

Open sonachitchyan opened this issue 2 years ago • 1 comments

:pencil: Description

Type: :roller_coaster: infrastructure Swtiched get_doppler_factor and get_inverse_doppler_factor to use v(velocity) instead of r(radial distance) Added nonhomologous_grip.py for future use of nonhomologous expansion. This part is not connected to anything in the code for now.

The right version of #2035

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

  • [ ] Testing pipeline
  • [ ] Other method (describe)
  • [ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

  • [ ] I requested two reviewers for this pull request
  • [ ] I updated the documentation according to my changes
  • [ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

sonachitchyan avatar Jul 01 '22 14:07 sonachitchyan

Codecov Report

Merging #2080 (943e29b) into master (8c1ec10) will decrease coverage by 0.85%. The diff coverage is 1.39%.

@@            Coverage Diff             @@
##           master    #2080      +/-   ##
==========================================
- Coverage   58.04%   57.18%   -0.86%     
==========================================
  Files          76       77       +1     
  Lines        8743     8874     +131     
==========================================
  Hits         5075     5075              
- Misses       3668     3799     +131     
Impacted Files Coverage Δ
...lo_numba/continuum/r_packet_transport_continuum.py 14.92% <0.00%> (-0.23%) :arrow_down:
tardis/montecarlo/montecarlo_numba/interaction.py 26.75% <0.00%> (-1.25%) :arrow_down:
.../montecarlo/montecarlo_numba/nonhomologous_grid.py 0.00% <0.00%> (ø)
tardis/montecarlo/montecarlo_numba/r_packet.py 49.01% <0.00%> (-0.99%) :arrow_down:
.../montecarlo/montecarlo_numba/single_packet_loop.py 25.71% <0.00%> (-1.16%) :arrow_down:
tardis/montecarlo/montecarlo_numba/vpacket.py 21.35% <0.00%> (-0.43%) :arrow_down:
tardis/transport/r_packet_transport.py 19.51% <0.00%> (-0.49%) :arrow_down:
tardis/transport/frame_transformations.py 51.02% <50.00%> (+2.00%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jul 01 '22 15:07 codecov[bot]