tardis icon indicating copy to clipboard operation
tardis copied to clipboard

Moved functions from gamma_ray_grid into files in transport folder.

Open nolanbrown01 opened this issue 2 years ago • 2 comments

:pencil: Description

Type: :roller_coaster: infrastructure

Split gamma_ray_grid.py into r_packet_transport_3d.py and calculate_distances_3d.py. Moved move_packet into the former and the other two functions into the latter. Renamed move_packet --> move_packet_3d ; distance_trace --> distance_trace_gamma ; calculate_distance_radial --> calculate_distance_boundary_3d . Renamed dependencies/calls.

:vertical_traffic_light: Testing

How did you test these changes?

  • [x] Testing pipeline
  • [ ] Other method (describe)
  • [ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

  • [x] I requested two reviewers for this pull request
  • [ ] I updated the documentation according to my changes
  • [ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

nolanbrown01 avatar Jun 29 '22 17:06 nolanbrown01

Codecov Report

Merging #2078 (d334c40) into master (a57ab47) will increase coverage by 0.01%. The diff coverage is 52.94%.

@@            Coverage Diff             @@
##           master    #2078      +/-   ##
==========================================
+ Coverage   58.04%   58.06%   +0.01%     
==========================================
  Files          76       77       +1     
  Lines        8743     8747       +4     
==========================================
+ Hits         5075     5079       +4     
  Misses       3668     3668              
Impacted Files Coverage Δ
tardis/transport/r_packet_transport_3d.py 42.85% <42.85%> (ø)
...ardis/transport/geometry/calculate_distances_3d.py 19.51% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jun 29 '22 17:06 codecov[bot]

I have the same question here as in #2079 about the naming of packet

sonachitchyan avatar Jun 30 '22 18:06 sonachitchyan

This is now outdated

andrewfullard avatar Jul 10 '23 15:07 andrewfullard