tardis
tardis copied to clipboard
Adding needed functionality to nonhom_grip.py
:pencil: Description
Adding nonhom_grid.py that includes velocity and $ \frac{dv}{dr}$ functions for shells and finding tau_sobolev_factor
Some of the changes shown here are part of https://github.com/tardis-sn/tardis/pull/2024
Also, link issues affected by this pull request by using the keywords: close
, closes
, closed
, fix
, fixes
, fixed
, resolve
, resolves
or resolved
.
:pushpin: Resources
Examples, notebooks, and links to useful references.
:vertical_traffic_light: Testing
How did you test these changes?
- [ ] Testing pipeline
- [ ] Other method (describe)
- [ ] My changes can't be tested (explain why)
:ballot_box_with_check: Checklist
- [ ] I requested two reviewers for this pull request
- [ ] I updated the documentation according to my changes
- [ ] I built the documentation by applying the
build_docs
label
Note: If you are not allowed to perform any of these actions, ping (@) a contributor.
Codecov Report
Merging #2035 (7e2a326) into master (b0b04ee) will decrease coverage by
3.74%
. The diff coverage is10.86%
.
:exclamation: Current head 7e2a326 differs from pull request most recent head 8ed512f. Consider uploading reports for the commit 8ed512f to get more accurate results
@@ Coverage Diff @@
## master #2035 +/- ##
==========================================
- Coverage 61.33% 57.59% -3.75%
==========================================
Files 75 77 +2
Lines 8602 8737 +135
==========================================
- Hits 5276 5032 -244
- Misses 3326 3705 +379
Impacted Files | Coverage Δ | |
---|---|---|
.../montecarlo/montecarlo_numba/nonhomologous_grid.py | 9.24% <9.24%> (ø) |
|
...montecarlo/montecarlo_numba/calculate_distances.py | 29.50% <16.66%> (ø) |
|
tardis/montecarlo/montecarlo_numba/numba_config.py | 100.00% <100.00%> (ø) |
|
tardis/visualization/widgets/custom_abundance.py | 16.56% <0.00%> (-42.97%) |
:arrow_down: |
tardis/io/config_validator.py | 89.47% <0.00%> (-1.01%) |
:arrow_down: |
tardis/montecarlo/montecarlo_numba/base.py | 29.75% <0.00%> (-0.76%) |
:arrow_down: |
tardis/montecarlo/montecarlo_configuration.py | 100.00% <0.00%> (ø) |
|
tardis/transport/geometry/calculate_distances.py | ||
tardis/transport/frame_transformations.py | ||
tardis/transport/r_packet_transport.py | ||
... and 10 more |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
This has been done now right?