tardis icon indicating copy to clipboard operation
tardis copied to clipboard

Published 20 hours ago • verified publisher icon tardis-sn

Move CSVY writer from custom abundance widget to io

Open Rodot- opened this issue 2 years ago • 5 comments

Is your feature request related to a problem? Please describe. Would be nice to have simpler access to the csvy writer for general model creation. Currently it is a part of the custom abundance widget, but the tool is generally useful.

Current location: https://github.com/tardis-sn/tardis/blob/e1181bd5ad3a382ed86ab4774ca77bcf964f0a94/tardis/visualization/widgets/custom_abundance.py#L1384

Describe the solution you'd like Move this over to the io module to make access easier.

Rodot- avatar Mar 14 '22 17:03 Rodot-

Hello , where exactly in the io module do you want this to be moved over to ? @Rodot-

umak1106 avatar Mar 14 '22 19:03 umak1106

Either in the same folder with the reader, or a new sub-module with writers. Be aware, the csvy writer needs to be rewritten a little to make sure it is independent of the widget.

Rodot- avatar Mar 14 '22 20:03 Rodot-

Hello @Rodot- Is this issue still open? If yes, I'm willing to contribte.

VedantGandhi04 avatar Feb 13 '23 19:02 VedantGandhi04

Yes, I believe it is technically still open though there is currently an old PR for this still open so it might be good to try another issue until we decide if we want to close the current open PR on this. I'll ping the reviewers for it to find out and let you know!

Rodot- avatar Feb 13 '23 19:02 Rodot-

Hi @Rodot- can I take this up? I see the earlier PR related to this issue was closed without merging.

AyushiDaksh avatar Mar 26 '23 07:03 AyushiDaksh