tardis icon indicating copy to clipboard operation
tardis copied to clipboard

Add units to BlackBodySimpleSource

Open isaacgsmith opened this issue 3 years ago • 4 comments

We would like to make the BlackBodySimpleSource.create_packets() method (in tardis/montecarlo/packet_source.py) unit-sensitive. That is, we would like to take in quantities with units and return quantities with units.

Additional context A potential thing to think about here is how this method is used in the code, and having that be unit-sensitive as well. Remembering that this class can be replaced by a user's own packet source, do we want to require that the user's function includes units? That may be something for @wkerzendorf to answer.

isaacgsmith avatar Jun 17 '21 01:06 isaacgsmith

Hey, I really wanna work on this issue. Can this issue be assigned to me please?

rishav-karanjit avatar Jan 24 '22 03:01 rishav-karanjit

Hi, is this issue still open? I want to know exactly how the unit will be taken as input?

jayantbhakar avatar Mar 12 '22 12:03 jayantbhakar

@wkerzendorf In case of Custom packet source, do we really want to force the user to take in quantities with units and return quantities with units?

AyushiDaksh avatar Mar 27 '23 01:03 AyushiDaksh

@wkerzendorf
Hey, I really want to work on this issue. As I am very curious about modern physics and also having a pretty good understanding about physics and Python as well. So please can this issue be assigned to me please?

laksh-krishna-sharma avatar Sep 10 '23 19:09 laksh-krishna-sharma