carsus icon indicating copy to clipboard operation
carsus copied to clipboard

Add opacties data reader for h minus ions

Open light2802 opened this issue 1 year ago • 4 comments

:pencil: Description

Type: :rocket: feature

Add reader for parsing H minus opacities data files [1].

:pushpin: Resources

[1] Reference opacities data

:vertical_traffic_light: Testing

How did you test these changes?

  • [ ] Testing pipeline
  • [ ] Other method (describe)
  • [ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

  • [ ] I requested two reviewers for this pull request
  • [ ] I updated the documentation according to my changes
  • [ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

light2802 avatar Jul 23 '23 14:07 light2802

Codecov Report

Merging #351 (c679ba5) into master (275c383) will decrease coverage by 7.29%. Report is 48 commits behind head on master. The diff coverage is 48.15%.

:exclamation: Current head c679ba5 differs from pull request most recent head 8ec5017. Consider uploading reports for the commit 8ec5017 to get more accurate results

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   74.44%   67.15%   -7.29%     
==========================================
  Files          23       30       +7     
  Lines        2614     3544     +930     
==========================================
+ Hits         1946     2380     +434     
- Misses        668     1164     +496     
Files Changed Coverage Δ
carsus/io/chianti_/chianti_.py 85.80% <0.00%> (+19.36%) :arrow_up:
carsus/io/nndc/base.py 0.00% <0.00%> (ø)
carsus/io/nndc/ensdf.py 0.00% <0.00%> (ø)
carsus/io/nndc/parsers.py 0.00% <0.00%> (ø)
carsus/io/opacities/opacities.py 0.00% <0.00%> (ø)
carsus/io/output/base.py 9.02% <7.61%> (-1.82%) :arrow_down:
carsus/io/atom_data_compare.py 12.97% <12.97%> (ø)
carsus/io/zeta.py 27.65% <16.66%> (-2.35%) :arrow_down:
carsus/io/nuclear/nndc.py 84.61% <84.61%> (ø)
carsus/io/cmfgen/base.py 87.14% <85.49%> (+3.14%) :arrow_up:
... and 5 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 23 '23 14:07 codecov[bot]

Tests would be great

andrewfullard avatar Jul 24 '23 14:07 andrewfullard

I think that generally h_minus is not a good name for a data structure/reader, and also we should go back to the source of the h_minus_cross_section_wbr.dat file and carry that along here. I believe that this comes from bell_free-free_1980 in the stardis documentation, but if the reader is specific to this source then we should mention it at such. Alternatively, if this is a generic h minus ion reader (which is preferable), then many parts of the documentation need to be changed to not specify the h_minus_cross_section file by name (i.e., line 69 in opacities.py)

jvshields avatar Aug 01 '23 18:08 jvshields

@jvshields is this going to be used for stardis? Does it need much more work?

andrewfullard avatar Aug 31 '23 14:08 andrewfullard