Tony Arcieri

Results 217 issues of Tony Arcieri

The `k256` crate uses lazy normalization of field elements. While not a user-facing concern as we deliberately encapsulate `FieldElement`, there is a potential for bugs in code in `k256` itself...

The `argon2` crate presently vendors its own implementation of the BLAKE2b round function for the core of the Argon2 KDF implementation: https://github.com/RustCrypto/password-hashes/blob/58bc6dd/argon2/src/block.rs#L100-L186 Ideally it'd be able to leverage an implementation...

enhancement
argon2

A parallel `rayon`-based implementation was added in #149, however it works by using raw pointers and creating mutable references from them. The references aren't aliased so in theory it should...

Following up from https://github.com/RustCrypto/meta/issues/10, this is an issue for discussion potentially adding "recommended" badges to certain algorithms in this repo: ![Recommended: Yes](https://img.shields.io/badge/recommended-yes-success.svg)

The current `argon2` crate implementation is a translation of `ref.c` from the reference implementation: https://github.com/P-H-C/phc-winner-argon2/blob/92cd2e1/src/ref.c It could be improved by translating `opt.c` instead, which provides e.g. SIMD support: https://github.com/P-H-C/phc-winner-argon2/blob/92cd2e1/src/opt.c

enhancement
argon2

Digest now makes use of several vaguely-named generic wrapper structs and type aliases to give them human-readable names. This makes both the type names emitted by rustc and the resulting...

digest

In upgrading many projects, I frequently ran into the following: ``` error[E0034]: multiple applicable items in scope | let mut mac = Aes128Cmac::new_from_slice(&key)?; | ^^^^^^^^^^^^^^ multiple `new_from_slice` found | =...

The `Mac::new` trait is defined as: ```rust fn new(key: &Key) -> Self where Self: KeyInit; ``` ...but it provides no default definition, requires `Self` impl `KeyInit`, and causes ambiguity: ```...

digest

This is a tracking ticket for 1.0 releases of all of the crates in this repository, except for `signature` which is already 1.0 (see #237). The main blocker for 1.0...

enhancement
help wanted
aead
signature
cipher
crypto-mac
univeral-hash
elliptic-curve
digest

We've had an informal plan to migrate from the `generic-array`/`typenum` crates for years. People ask about it quite frequently ever since `min_const_generics` have been stabilized. I thought it would be...