Tony Arcieri

Results 2560 comments of Tony Arcieri

With #125 merged I think this can be closed

Another option would be making a separate `integration-tester` (or thereabouts, really it's an acceptance test suite, right?) crate with its own workspace / Cargo.lock resolution, and placing the code this...

Sorry, yes I need to do that and I'm not really familiar with how

I'll see if I can look soon

Failed on `npm install`: ``` npm error code E401 npm error 401 Unauthorized - GET https://npm.pkg.github.com/download/@clechasseur/rs-actions-core/3.0.5/b35ae1eb71c59dd75c7db9ecccba1bd7f3a2fc99 - authentication token not provided ``` (I've done `npm login`, FWIW) npm v10.7.0

I wasn't able to login at all with that. I attempted to use my GitHub credentials, and got the following: ``` npm error code E403 npm error 403 403 Forbidden...

Okay, the issue with the above is the "password" is actually a personal access token. I was able to login successfully but: ``` npm error code E403 npm error 403...

Okay, I attempted to publish a new release here: https://github.com/rustsec/audit-check/releases/tag/v2.0.0

We should review all constants that went into synthesizing the field implementations, as well as the `PrimeCurveParams` constants (curve equation, generator).

#879 was the commit that reverted the `arithmetic` feature. It's been awhile but it says ECDH was failing. It would be good to add test vectors similar to these: https://github.com/RustCrypto/elliptic-curves/blob/master/p256/src/test_vectors/group.rs