Tony Arcieri
Tony Arcieri
To be clear @dignifiedquire tried to add generic mulmod in RustCrypto/utils#510 but it was buggy so we backed it out. It would be great to have a generic implementation.
@mikelodder7 should be updated now
Sorry, I reorganized the modular arithmetic section, and missed a few things along the way. Note there is `sqrt` under modular arithmetic. However, I'll move inversions there.
Modular sqrt could potentially be helpful for the elliptic curve crates, although we're presently using an algorithm (Tonelli-Shank) specialized to the modulus (q mod 16 = 1). I'm not sure...
Optional `num_traits` support sounds great. I would suggest following the same pattern as all the other functions that can presently support it which are currently impl'd on `UInt` (and `Limb`)...
See #312 for some previous discussion about widening semantics. The main strategy we currently provide to prevent overflow is widening multiplication, where the result is the size of the sum...
@tgross35 can you rebase? That should fix the test failure
I think this might make sense the other way around: if each cipher were to include `block-modes` as an optional dependency. The reason is the number of ciphers we support...
Sure. Curious what @newpavlov thinks though.
It seems less necessary after 1.0 because you'll know 1.0 crates are compatible with each other, but that said, it still seems convenient. I'm not sure when we'll even be...