Tony Arcieri

There's not a whole lot we can do here. The core problem is Miri performance. You can `allow(long_running_const_eval)`, but the compile times seem perhaps prohibitively slow. In such cases where...

@spitters it won't help here, since this question is about `const fn` usage, and `s2n-bignum` is a C/ASM library which isn't callable from `const fn` contexts

@spitters note, however, that we do have a general tracking issue for incorporating the assembly from `s2n-bignum`: #572

The proposed bigint helper methods in core (https://github.com/rust-lang/rust/issues/85532) use the following names: - `carrying_add` - `borrowing_sub` - `carrying_mul` - `widening_mul` Perhaps it would be good to generally align names and...

We've had several requests to improve documentation on this library and I agree it's a general problem. But I'm left feeling like @fjarri that I'm not sure what specific kinds...

To answer this question: > Is this function constant or variable time? https://github.com/RustCrypto/crypto-bigint#goals > Constant-time by default. Variable-time functions are explicitly marked as such. I'm not sure if that's not...

> DynResidue/Residue. Which I always considered to be a confusing name for numbers in Montgomery space :) Open to better names... that one came from quite a bit of bikeshedding....

@drcapybara I think your example could be OK, however it shouldn't use `unwrap`, but instead something like: `NonZero::new(...).map { |b| a.div_rem(&b) }`

Looks good so far

I published v0.1.0 releases of the following crates largely as-is: - `jose-b64` - `jose-alg` - `jose-jwk` - `jose-jws` We didn't quite tick all of your checkboxes and I think this...