Tony Arcieri
Tony Arcieri
@dishmaker [I already proposed simply getting rid of `NestedReader`](https://github.com/RustCrypto/formats/issues/1228#issuecomment-1780064957), instead changing `read_nested` from a provided method to one each reader must impl (but they may be able to reuse parts...
> Well, how would you track the outer nested boundary when entering another nest? In the reader type itself. > Well, how would you track the outer nested boundary when...
> It is necessary, because read_slice() and remaining_len() relies upon current nest bounds. Again, that can be stored in the reader type, which those methods are defined on.
> Also, i've correctly implemented peeking by simplifying peek_byte into peek_bytes I'm not sure your implementation is going to work on `PemReader`?
> You can't store u32 in a trait. You store `u32` (or rather, `Length`), in a type which impls the `Reader` trait, and query it via the accessor methods you...
> GzipReader, ZlibReader, ZstdReader, ZstdPemReader, AesDeflateReader etc.. If you actually have legitimate use cases for these, feel free to open a separate issue, but it seems more like you are...
@dishmaker please open a separate issue for that, because it’s irrelevant to this problem
@carl-wallace as I mentioned, we can still have `*Ref` types which would be useful for #689
@baloo for now I’d say make everything owned, and circle back in `*Ref` types later as part of #689, which needs additional design work anyway
> Could we have proc macros emit a second set of structures Really if we want to have unified borrowed/owned types I would suggest evaluating `yoke` for this purpose (see...