http icon indicating copy to clipboard operation
http copied to clipboard

Remove redundant URI path segment check in parse_request

Open eugenepaniot opened this issue 1 year ago • 1 comments

This commit proposes the removal of a redundant URI path segment check within the parse_request function.

Currently, the code contains a loop that iterates over each path segment in the parsed URI, checking for the presence of . or .. segments. However, this check is unnecessary since HTTP requests with /./ or /../ in the URI are automatically corrected by the http server, converting them into // which is the expected behavior.

The primary reason for removing this check is to address an issue detailed in the GitHub pull request https://github.com/tarantool/http/pull/173. In cases where Tarantool decodes a request like .%2F.html.%2F to ./.html./, the current code implementation throws an invalid uri error. However, this behavior is not desired. Instead, it is expected to return the URI as is.

eugenepaniot avatar Aug 18 '23 14:08 eugenepaniot

Please rebase with master branch.

0x501D avatar Dec 08 '23 08:12 0x501D