http icon indicating copy to clipboard operation
http copied to clipboard

VERSION always unknown

Open theonedemon opened this issue 4 years ago • 3 comments

local VERSION = 'unknown'
if package.search('http.VERSION') then
    VERSION = require('http.VERSION')
end

file VERSION.lua contains in .gitignore and always build package has "unknown" version

theonedemon avatar May 29 '20 06:05 theonedemon

issue is related to http-v2 that is now deprecated.

ligurio avatar Nov 10 '21 11:11 ligurio

We can implement the similar mechanism for http v1 too, if it is useful. Personally I several times meet the situation, when a user answers "I don't know" for "which version of a module is installed on your system?".

Brief checklist (for a module with Lua/C, pure Lua would differ a bit):

  • [ ] Correct version in a module installed using tarantoolctl rocks install <module> <version> (from rockspec as well as from src.rock).
  • [ ] The same for scm-1 (only rockspec).
  • [ ] The same for tarantoolctl rocks make in a git repository.
  • [ ] The same for cmake . && make build.
  • [ ] The same for RPM / Deb packages.

(Am I missed something?)

Totktonada avatar Nov 11 '21 00:11 Totktonada

Isn't it solved by https://github.com/tarantool/http/pull/184?

DifferentialOrange avatar Sep 18 '23 12:09 DifferentialOrange