crud icon indicating copy to clipboard operation
crud copied to clipboard

Dishonest schema reload timeout

Open DifferentialOrange opened this issue 3 years ago • 0 comments
trafficstars

There is a problem with this timeout:

local function call_reload_schema(replicasets)
    for _ = 1,replicasets_num do
        if channel:get(const.RELOAD_SCHEMA_TIMEOUT) == nil then
            for _, f in ipairs(fibers) do
                if fiber:status() ~= 'dead' then
                    f:cancel()
                end
            end
            return nil, ReloadSchemaError:new("Reloading schema timed out")
        end
    end
...
end

replicasets_num * const.RELOAD_SCHEMA_TIMEOUT may require much more time than const.RELOAD_SCHEMA_TIMEOUT

Originally posted by @oleg-jukovec in https://github.com/tarantool/crud/pull/319#discussion_r951224342

DifferentialOrange avatar Aug 26 '22 12:08 DifferentialOrange