cartridge-java icon indicating copy to clipboard operation
cartridge-java copied to clipboard

Published 20 hours ago • verified publisher icon tarantool

Remove or fix withReadTimeout

Open ArtDu opened this issue 2 years ago • 3 comments

It doesn't do anything right now

ArtDu avatar Jan 20 '23 11:01 ArtDu

It should set a read timeout for a request if I understand correctly what this ticket is about.

akudiyar avatar Feb 02 '23 17:02 akudiyar

For request timeout we have requestTimeout, but read timeout isn't being used in code

ArtDu avatar Feb 20 '23 15:02 ArtDu

The proper solution for this is to use https://github.com/netty/netty/blob/4.1/handler/src/main/java/io/netty/handler/timeout/ReadTimeoutHandler.java. It seems the option was added with that in mind, but the handler was not added.

akudiyar avatar Feb 20 '23 20:02 akudiyar