cartridge-cli icon indicating copy to clipboard operation
cartridge-cli copied to clipboard

Add availability to hide spinner

Open hackallcode opened this issue 3 years ago • 6 comments

In GitHub Actions on pack stage I have a spinner that makes such logs:

   • Building base image myapp-build

|
/
-
\
|
/
-
\
|
/
-
\
|

So, I want to disable the spinner in CI. Let's add a flag to do it.

hackallcode avatar Nov 10 '21 10:11 hackallcode

Whether you'll be okay if we'll just fix its displaying? Or it looks so, when you write the log to a file?

Seems similar to #627.

Totktonada avatar Nov 10 '21 11:11 Totktonada

It's not similar to #627.

You can just fix displaying, yes. For example, if the console doesn't support \r then hide spinner, but if supports then show it.

GH Actions doesn't support \r, so we can see hundreds of spinner lines instead of one line.

hackallcode avatar Nov 10 '21 12:11 hackallcode

Could it just check if the shell is non-interactive and turn off the spinner?

NickVolynkin avatar Nov 11 '21 04:11 NickVolynkin

If it works in GH Actions, it's ok

hackallcode avatar Nov 11 '21 06:11 hackallcode

same here, really annoying image

vasiliy-t avatar Nov 23 '21 09:11 vasiliy-t

it's runes

filonenko-mikhail avatar Nov 23 '21 09:11 filonenko-mikhail