cartridge-cli icon indicating copy to clipboard operation
cartridge-cli copied to clipboard

Support for custom app versioning (non-semantic)

Open RunsFor opened this issue 4 years ago • 4 comments

Right now, cartridge-cli requires cartridge apps to have semantic versioning even for tar.gz packages. However, customers may have their own version policies for their apps. Can we add support for custom version policies?

Here is a reproducer:

$ cartridge create --name myapp
   • Create application myapp
   • Generate application files
   • Initialize application git repository
   • Application "myapp" created successfully
$ cd myapp
$ touch file
$ git add file
$ git commit -m "update repo"
[master 091637d] update repo
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 file
$ git tag v0.1.0
$ cartridge pack tgz .
   • Packing myapp into tgz
   ⨯ Version should be semantic (major.minor.patch[-count][-commit])

RunsFor avatar Feb 18 '21 15:02 RunsFor

I would propose to solve #415 and suggest to pass VERSION variable if tags are different from X.Y.Z schema (say, have 'v' prefix).

Totktonada avatar Jul 23 '21 15:07 Totktonada

However, okay, those are different issues. Your (and #552) proposal is about arbitrary versioning.

Totktonada avatar Jul 23 '21 15:07 Totktonada

To be honest, I don't know why the decision about enforcing semver was made. So I don't know, whether it'll be appropriate to change it.

@dokshina Can you shed some light there?

Totktonada avatar Jul 23 '21 15:07 Totktonada

I know that history. This decision was made by @knazarov cause forcing of right practice is a good thing.

Kasen avatar Jul 26 '21 10:07 Kasen