[feat]: Add functionality to delete a wish
What does this PR do?
This PR adds functionality to delete a wish with confirmation fixes #2
How to test?
- setup project
- run project on http://localhost:3000
- then add some wish
- then try to delete some of them
Screenshots or Videos
https://github.com/tapascript/solid-bucket-list/assets/84084280/49de7cee-3967-4d03-a13c-8bea5796e7e6
Type of change
- [x] New feature (non-breaking change which adds functionality)
How should this be tested?
- this can be test manually
- also if we want, We can write unit tests and e2e test to ensure full safety
@Mohimkhan Please resolve the merge conflicts
@atapas Sir, I haven't committed my changes yet. I will look into this and resolve the conflicts.
@Mohimkhan Please resolve the merge conflicts
@atapas Sir, I have gone through evey confilcts and I think i can resolve them but it might take some time as I have to rewrite the css in tailwind and also some other things. Iam working on it
@Mohimkhan Please resolve the merge conflicts
@atapas Sir, I have gone through evey confilcts and I think i can resolve them but it might take some time as I have to rewrite the css in tailwind and also some other things. Iam working on it
Try to create a separate branch and start work with it will help you to avoid conflict
@Mohimkhan Please resolve the merge conflicts
@atapas Sir, I have gone through evey confilcts and I think i can resolve them but it might take some time as I have to rewrite the css in tailwind and also some other things. Iam working on it
Try to create a separate branch and start work with it will help you to avoid conflict
Thank you @sarowarhosen03 but I have already fetch the changes to my current branch (feat/functionality-to-delete-a-wish) and also solve 2 conflicts, now i just have to rewrite the css to tailwind and also check if deleteing a wish makes changes in localstorage
@Mohimkhan Please resolve the merge conflicts
@atapas Sir, I have gone through evey confilcts and I think i can resolve them but it might take some time as I have to rewrite the css in tailwind and also some other things. Iam working on it
Try to create a separate branch and start work with it will help you to avoid conflict
Thank you @sarowarhosen03 but I have already fetch the changes to my current branch (feat/functionality-to-delete-a-wish) and also solve 2 conflicts, now i just have to rewrite the css to tailwind and also check if deleteing a wish makes changes in localstorage
#19 if this PR merged you don't need to do anything for deleting or updating items on localstorage . Just update the main state it will automatically update on localstorage
@Mohimkhan Please resolve the merge conflicts
@atapas Sir, I have gone through evey confilcts and I think i can resolve them but it might take some time as I have to rewrite the css in tailwind and also some other things. Iam working on it
Try to create a separate branch and start work with it will help you to avoid conflict
Thank you @sarowarhosen03 but I have already fetch the changes to my current branch (feat/functionality-to-delete-a-wish) and also solve 2 conflicts, now i just have to rewrite the css to tailwind and also check if deleteing a wish makes changes in localstorage
#19 if this PR merged you don't need to do anything for deleting or updating items on localstorage . Just update the main state it will automatically update on localstorage
so should i wait for it to merge or I can do the other things and I will not do anything to delete items in localStorage but if i can finished my work and it didn't get merge then i will do what ever necessay. I have gone through your changes and i think the only conflicting files for me after you PR get merge will be (AddToBucket, BucketList, App) . I think the conflicts will be small if any of our PR gets merged. Whats your thought on this
@Mohimkhan Please resolve the merge conflicts
@atapas Sir, I have gone through evey confilcts and I think i can resolve them but it might take some time as I have to rewrite the css in tailwind and also some other things. Iam working on it
Try to create a separate branch and start work with it will help you to avoid conflict
Thank you @sarowarhosen03 but I have already fetch the changes to my current branch (feat/functionality-to-delete-a-wish) and also solve 2 conflicts, now i just have to rewrite the css to tailwind and also check if deleteing a wish makes changes in localstorage
#19 if this PR merged you don't need to do anything for deleting or updating items on localstorage . Just update the main state it will automatically update on localstorage
so should i wait for it to merge or I can do the other things and I will not do anything to delete items in localStorage but if i can finished my work and it didn't get merge then i will do what ever necessay. I have gone through your changes and i think the only conflicting files for me after you PR get merge will be (AddToBucket, BucketList, App) . I think the conflicts will be small if any of our PR gets merged. Whats your thought on this
Yes you're right. Let's see which pr got merge first
@Mohimkhan Please resolve the merge conflicts
@atapas Sir, I have gone through evey confilcts and I think i can resolve them but it might take some time as I have to rewrite the css in tailwind and also some other things. Iam working on it
Try to create a separate branch and start work with it will help you to avoid conflict
Thank you @sarowarhosen03 but I have already fetch the changes to my current branch (feat/functionality-to-delete-a-wish) and also solve 2 conflicts, now i just have to rewrite the css to tailwind and also check if deleteing a wish makes changes in localstorage
#19 if this PR merged you don't need to do anything for deleting or updating items on localstorage . Just update the main state it will automatically update on localstorage
so should i wait for it to merge or I can do the other things and I will not do anything to delete items in localStorage but if i can finished my work and it didn't get merge then i will do what ever necessay. I have gone through your changes and i think the only conflicting files for me after you PR get merge will be (AddToBucket, BucketList, App) . I think the conflicts will be small if any of our PR gets merged. Whats your thought on this
You can work on a separate branch. In future if you need to pull something on your main branch. You can fix the merge conflict locally
Deploy Preview for solidbucketlist ready!
| Name | Link |
|---|---|
| Latest commit | 2cd38dbf087ab1ddb71d6406016ea5d7c9dd4712 |
| Latest deploy log | https://app.netlify.com/sites/solidbucketlist/deploys/6556e21efd6f8100089d1b0b |
| Deploy Preview | https://deploy-preview-8--solidbucketlist.netlify.app/ |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@atapas Sir, I have resolve all the conflicts. please check if it needs anything