TDengine icon indicating copy to clipboard operation
TDengine copied to clipboard

fix: perf test errors

Open dapan1121 opened this issue 2 months ago • 2 comments

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

  • [ ] Is the user manual updated?
  • [ ] Are the test cases passed and automated?
  • [ ] Is there no significant decrease in test coverage?

dapan1121 avatar Oct 27 '25 03:10 dapan1121

Summary of Changes

Hello @dapan1121, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses several issues and introduces enhancements primarily focused on stream calculation queries and their interaction with window functions and timestamp handling. It refines how the system processes queries without a 'FROM' clause in stream contexts, correctly identifies new timestamp functions, and includes specific fixes to resolve performance test errors, alongside general improvements to error handling within the planner.

Highlights

  • Stream Calculation Query Enhancements: Improved handling of stream calculation queries, especially those without a 'FROM' clause, by introducing dedicated logic for external window nodes and adjusting timeline resolution.
  • Timestamp Function Recognition: Expanded the parser and planner to correctly identify various timestamp-related functions (e.g., TPREV_TS, TCURRENT_TS) as primary key-like or primary timestamp columns.
  • Performance Test Fixes: Enabled the 'TRIGGER_USE_HISTORY_META' flag and adjusted history recalculation logic to include the 'fillHistoryFirst' condition, addressing issues in performance tests.
  • Refactored Error Handling: Standardized error handling in the physical plan creation process using 'PLAN_ERR_JRET' macros for improved robustness and consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Oct 27 '25 03:10 gemini-code-assist[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: Simon9997
:x: dapan1121
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 28 '25 03:10 CLAassistant