Add clj-kondo hooks

[ericdallo]

This should make clj-kondo understand the defalias custom macro and correctly lint it as an alias, this PR also add the hook config to resources classpath following export feature, this make clj-kondo understand this macro on any lib that uses encore for example taoensso.timbre/spit-appender, the user only needs to add to its clj-kondo config a {:config-paths ["taoensso/encore"]}.

Some examples of other libs that did the same: midje, state-flow

[ericdallo]

LMK if any questions @ptaoussanis :)

[ptaoussanis]

@ericdallo Hi Eric, apologies for the long delay getting back to you on this! I've never used kondo, so not too familiar with the details on this.

Just double checking if the PR is still up-to-date / relevant? If so, will get it merged as part of the next Encore release.

Thanks!

[ericdallo]

No problem @ptaoussanis! Yes, it's still relevant as it should help users of encore and clj-kondo (via clojure-lsp as well) have that config automatically and make linter and other features happy :)

[ptaoussanis]

Merging now, thanks Eric!

[jumarko]

@ericdallo I don't see where the dependency on clj-kondo is defined in the project. In fact, I'm getting these errors in one of my projects (when loading taoensso.encore)

1. Caused by java.io.FileNotFoundException
   Could not locate clj_kondo/hooks_api__init.class, clj_kondo/hooks_api.clj or
   clj_kondo/hooks_api.cljc on classpath. Please check that namespaces with dashes use underscores
   in the Clojure file name.

[ptaoussanis]

@jumarko Hi Juraj, while waiting for a reply from Eric - I'd like to ask in the meantime:

In fact, I'm getting these errors in one of my projects (when loading taoensso.encore)

What do you mean by "loading" here? Can you be more specific about exactly what command you're running? What build tool are you using?

Thanks!

[ericdallo]

This works following clj-kondo exports feature, basically the encore lib how has under resources folder the clj-kondo hooks configuration, when clj-kondo is lining a project that has encore as the lib dependency, clj-kondo will scan the encore jar and find this clj-kondo config as it's available on the classpath, all what the user needs to do is include this on it's project:

.clj-kondo/config.edn

{:config-paths ["taoensso/encore"]}

[jumarko]

@ptaoussanis I'm trying to use datalevin that requires encore. I had encore set in my deps.edn file explicitly but it was too old so I decided to upgrade to the latest version of encore. However, when I required dataleving.core it failed (transitively) because of encore:

(ns clojure-experiments.datomic.datalevin
  "https://github.com/juji-io/datalevin/blob/master/README.md"
  (:require
   [datalevin.core :as d]))

trying to load the above ns definition fails:

Syntax error macroexpanding taoensso.encore/defalias at (taoensso/encore.cljc:541:6).
[encore/defalias] Failed to resolve source var

It works using encore version 3.30.0 (chosen more or less randomly looking at the releases that were made before this PR was merged).

I was wondering why it couldn't find the var and thus the namespace. Thus I opened the encore jar and tried to load encore.clj - I didn't realize it was actually the one in clj-kondo.exports/...

That's the reason why I thought it's related to this change. But it seems that problem is different - maybe it has something to do with the truss version in my project?

[ptaoussanis]

Syntax error macroexpanding taoensso.encore/defalias at (taoensso/encore.cljc:541:6).

Just to confirm: this error should also mention what the exact var is couldn't be resolved. It's taoensso.truss/with-data? If so, it sounds like you may have a dependency conflict involving Truss.

Are you manually including Truss in your own project? If so, please make sure that you're either on the latest version - or just let Encore bring in an appropriate version automatically.

Some info to help you debug here.

[jumarko]

Upgrading to truss 1.8.0 indeed fixed the problem. Thanks for the help!

[ptaoussanis]

No problem Juraj, thanks for the confirmation. And thanks @ericdallo!