PEGTL icon indicating copy to clipboard operation
PEGTL copied to clipboard

Published 20 hours ago • verified publisher icon taocpp

add msys2 CI

Open Totto16 opened this issue 1 year ago • 2 comments

This adds a Msys2 CI.

I tested it in Msys2 Clang64 locally and fixed #365 too. For that I also had to change some code, so that Msys2 uses windows wide string functions to open a file, otherwise it wouldn't work.

Totto16 avatar Aug 11 '24 13:08 Totto16

CI failures are unrelated to this PR, macos-11 isn't available anymore as github runner, and the clang versions that fail are also not available anymore in the ubuntu runners 😓

Totto16 avatar Aug 11 '24 18:08 Totto16

I'll send a new PR fixing the CI by today later.

uilianries avatar Aug 12 '24 06:08 uilianries

@uilianries Any update?

ColinH avatar Sep 14 '24 09:09 ColinH

@ColinH Sorry, totally missed it. I'm going to check it now.

uilianries avatar Sep 14 '24 09:09 uilianries

@ColinH Sorry the confusion, the PR #367 is the fix that I mentioned before. Just need a review to be merged.

uilianries avatar Sep 14 '24 09:09 uilianries

Is #367 the only PR that we need to merge now? In other words, did you incorporate the MSYS2 fixes into #367?

ColinH avatar Sep 14 '24 11:09 ColinH

Is #367 the only PR that we need to merge now? In other words, did you incorporate the MSYS2 fixes into #367?

Yes, I rebased those changes via the commit https://github.com/taocpp/PEGTL/pull/366/commits/8171fc48917a30fc259308336a0551e787b58c43

uilianries avatar Sep 15 '24 08:09 uilianries

Thank you @uilianries for your work ❤️

Totto16 avatar Sep 15 '24 18:09 Totto16

@ColinH would it be possible to have new release, since now mysys2 is fully supported and works again?

Totto16 avatar Sep 15 '24 18:09 Totto16

The main branch already has some changes towards a PEGTL 4.0 which I'm otherwise working towards on the work branch; the 4.0 with MSYS2 support will be released when it's ready.

ColinH avatar Sep 16 '24 17:09 ColinH