meanTorrent icon indicating copy to clipboard operation
meanTorrent copied to clipboard

Updated English strings

Open pmwoodward3 opened this issue 7 years ago • 5 comments

I found and fixed some issues in the english translation.

Commit Message Guidelines

Header
Blank Line
Body
Blank Line
Footer

The header should look like:
<type>(<scope>): <subject>

The body should have any necessary detailed info about the commit:
An example, references as to where this idea came from, etc.

The footer should have all the issues tagged:
Fixes #123, Fixes #456

So a commit should look like:
feat(users): Add new Yahoo authentication

Yahoo authentication idea proposed by @codydaig
Example implementation in file.js

Fixes #82
  • Types:
    • feat - Features, Enhancements, and overall Improvements
    • fix - Fixes, Bugs, HotFixs, etc...
    • doc - Changes to the Documentation and doesn't actually touch any code.
  • Scope:
    • The scope should be where the change took place.
    • Examples: users, core, config, articles
  • Subject:
    • The subject line should be clear and concise as to what is being accomplished in the commit.
  • General Rules:
    • No Line in the Commit message can be longer than 80 characters.
  • Reference: Angular Conventions

pmwoodward3 avatar May 18 '17 13:05 pmwoodward3

@pmwoodward3 glad to see you, and in trans-string-en.js, the Sing out, Sing in, Sign up is origin from mean.js, and all route, controller method, api name are used these string, so i don't want to change it, but other trans all are very well, then how can i accept the Pull Request with out the Sign ** string?

taobataoma avatar May 19 '17 02:05 taobataoma

@pmwoodward3 I will try to use Commit Message Guidelines next commit, ;)

taobataoma avatar May 19 '17 02:05 taobataoma

@taobataoma is this still problematic to merge? I don't understand, why it should be a problem to change the english strings (the string vars aren't changed), when chinese does not use the english strings at all (and obviously still works). Should we rebase this commit on latest master and resubmit it? If the problem is still the same, can you make a list of non-translatable strings?

Shadowghost avatar Jun 10 '18 08:06 Shadowghost

Why did you close this @katoxi ?

deed02392 avatar Jun 14 '19 10:06 deed02392

Why did you close this @katoxi ?

Cause i [May 23, 2019] base on you PU update the file... https://github.com/taobataoma/meanTorrent/commit/1735d9a3c0f68d3101aeb0b1a697d1f795ef0138 https://github.com/taobataoma/meanTorrent/commit/7c218d8629e2486e1de652d630b0e06ea2b33340 If the new update or old translate still have translate problem or can improve it... I will help taobataoma update or merge it...

Sorry again that i closed you PU, now reopen this PU.

katoxi avatar Jun 14 '19 14:06 katoxi