Mauricio Tano
Mauricio Tano
> Numerical diffusivity seems to have improved a lot for SOU and Minmod. Quick and Ventakakrishnan seem to still be very diffusive. Do we expect this for these two? Is...
No. They are not. What makes you think that? The tests are in a very corse mesh. The actual limiting tests are done for a finer mesh
> because on your figure at the top of this thread, these two (Venta, QUICK) have results on that 2D case that look very much like 1st order upwind, while...
> actually this last commit should be squashed in a previous one see [dc52825](https://github.com/idaholab/moose/commit/dc5282514b9d8f5a2678a063c5131276b6a14669) [15691c9](https://github.com/idaholab/moose/commit/15691c99b6f9a23b5a9c19ee54f3c4b3452a69f4) > > you re checking in 8 gold files twice I will delete the gold...
Once the PR is ready, please consider adding a technical reviewer as per our suggested merge standards to NS. Thanks!
Good for me to merge once the test are passing. Thank you for the work @GiudGiud! Edit: Sorry, could we please add at least one test using kernels? Currently this...
@grmnptr @GiudGiud - could you please do the code review? @freiler - could you please do the technical review? I normally run the tests in the flow test bed and...
Yes, on it now
Also, @GiudGiud the syntax of the TKE input will likely change when we merge kOmegaSST, which is currently ready (we are doing the flow test bed testing before merge). Do...
Ramiro, @freiler, could you please do a technical check here? You will find the reference here: [Henkes, R. A. W. M., Van Der Vlugt, F. F., & Hoogendoorn, C. J....