tannerhelland
[BUG] - Light-colored top menu bar despite system-wide dark theme setting
Version information
2024.12
Describe the bug
The application's top menu bar appears in light theme while the rest of the application respects the system-wide dark theme setting.
How can I reproduce the bug?
Steps to Reproduce:
- Enable system-wide dark theme in Windows 11 settings
- Download PhotoDemon 2024.12
- Launch PhotoDemon
- Observe the top menu bar
Actual Result:
Top menu bar displays with light theme colors, creating inconsistency with the rest of the dark-themed application
Expected Result:
Top menu bar should match the system-wide dark theme setting, maintaining visual consistency throughout the application
Sample images and/or screenshots
Thank you!
As a "thank you" for your help, I am happy to add your name to PhotoDemon's contributor list. Please let me know what name (and optional website link) you'd like me to use. Pasha Suprunchuk https://github.com/suprunchuk
Thank you for suggesting this change, @suprunchuk . A similar issue was raised in https://github.com/tannerhelland/PhotoDemon/issues/397 . Let me quote my comment from that thread:
Themed menus and title-bars are on my TODO list and I completely agree: PhotoDemon would benefit greatly from them. I have already merged code to activate a dark title-bar but it looks atrocious with PhotoDemon's current bright menus, so I have disabled that feature until PhotoDemon's menus can be properly dark-themed.
It is hard to find time to address issues that are primarily cosmetic, especially when the workload involved is large.
I will keep this issue open and hopefully find time for it at some point in the future.
Just discovered Windhawk, a tweaks tool for Windows and there's a tweak there for enabling dark mode in Win32 menus, based on this code: https://github.com/adzm/win32-darkmode
It doesn't work on the top menu bar in PhotoDemon, but it does apply to the pullouts. Perhaps some tweaking can get the top-bar to work -- with this method, you wouldn't have to owner-draw the entire menu
Thank you for sharing that find, @Kroc! Looks like a nice solution for menus on Win 10+ builds.