Tanner Gooding

Results 380 comments of Tanner Gooding

You should also validate the behavior against negative numbers (e.g `-1.0`) and positive nan (well technically a nan with the inverse sign of `Double.NaN`/`Single.NaN`, but those are typically a negative...

> adding those tests revealed a weird little bug in Math.Max. That is possibly related to a bug that is already fixed and will be in the next patch release...

> I think it's probably best not to mimic the bug from LINQ. Noting that LINQ isn't a "bug" here, just a method with an inconvenient name. The IEEE 754:2008...

> seemingly making NaN the lowest number, so it only affects Min, not Max. Missed this bit. This does seem like a bug and an undesirable one at that. If...

I particularly like the idea of putting `const` somewhere in the expression to indicate that the result must be considered "constant" (and therefore non-allocating, etc). I feel like this could...

Some feedback/questions about the design were raised here: https://github.com/dotnet/csharplang/discussions/5983

If `private void` partial-methods are not required, and `non-void` partial methods (any accessibility) are required, would `non-private void` partial methods be required? Would it be worth something allowing the user...

(To clarify, I mean a specific instance is required so we don't break back-compat).

The latter is a struct which is 1025 bytes in size. The former is an inline array of 1025 elements, where each element is a DXGI_RGB struct instance.

Yes. Fixed-size buffers are an existing language syntax (which this proposal is extending) and are different from normal arrays (which are heap allocated and tracked by the GC). The syntax...