Tanner Dolby
Tanner Dolby
@schalkneethling No problem! I've looked through the proposed changes here and couldn't pinpoint exactly what caused the issue when it was previously merged. If we can figure out how to...
You're welcome @escattone! I have the time/desire to see this through so I'm happy to stick around until we pinpoint the root cause. I've done the steps you suggested and...
In this [comment](https://github.com/mdn/yari/issues/2489#issuecomment-824846723), Peter mentions, "So now, for en-US, it will crash the CI build, for translated-content it will just be a console.warn". Which is what I'm seeing, it will...
@schalkneethling No problem! Thanks for keeping this PR alive. I am beginning to wonder if this is still relevant after the redesign as well. If there was a metric that...
@caugner 👋 Sure thing. I filled out the PR template to provide some context for the proposed changes. I will merge this branch with `main` shortly and resolve conflicting files.
No problem! :) @caugner. Let me know if you need me to update anything in the meantime to help with your review.
@schalkneethling I implemented the requested changes for `DisplayHeading` to be utilized and things are looking good. It seems everything is passing besides the "Functional Testing" for the Testing Yari /...
@caugner Thanks for review so far. I've added the suggestions you had and everything is running now. The only problem is that [functional testing](https://github.com/mdn/yari/runs/8180806801?check_suite_focus=true) is failing and`` elements don't have...
Yeah I was using Chrome when I viewed the page. Haven't had a look at the page in Firefox. > Maybe we should face reality and remove interactive examples for...
Having your eyes on this would be great @schalkneethling !