notifications-preview-github icon indicating copy to clipboard operation
notifications-preview-github copied to clipboard

No notification number in the bubble if `Show only participating notifications` is enabled

Open darkred opened this issue 5 years ago • 0 comments

(follow-up to https://github.com/tanmayrajani/notifications-preview-github/issues/89#issuecomment-618091190)

(Tested extension 20.4.22 in a fresh Chrome 81/Firefox 75 profile)

if I enable Show only participating notifications then the notification number in the bubble is no longer displayed, even if Show notification number in blue bubble remains enabled.

The following error is repeatedly shown in console :

(github-notifications-preview.js:386) 
Uncaught (in promise) TypeError: Cannot read property 'textContent' of null 
     at $i4sc$var$updateUnreadCount 

Screenshot comparison having Show only participating notifications :

Disabled --> notification number (4) is displayed ok

2020-05-01_214015

Enabled --> notification number (2) is missing

2020-05-01_214100

darkred avatar May 01 '20 18:05 darkred