Rikito Taniguchi

Results 134 comments of Rikito Taniguchi

@deusaquilus Yes, and it's already done by @ckipp01 :tada: here https://github.com/sbt/sbt/commit/f90b09f1ee3ffd46100773d302d7aff60369f741

closing for now as it would be easier to re-work based on https://github.com/scalameta/metals/pull/4234, but anyone wants to work from this, feel free to re-open :)

@PeuTit Thank you for your interest! ## some context - Metals has a FileWatcher that observes file modification, creation, and deletion under the projects - [FileWatcher.scala](https://github.com/scalameta/metals/blob/c80f730d27092e6b1c51552c90bc9c7d5ec05421/metals/src/main/scala/scala/meta/internal/metals/watcher/FileWatcher.scala#L37) - `MetalsLanguageServer` instantiate the...

Oh, we commented on the same timing! > Great to hear! We would probably need to add additional method: > https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_didDeleteFiles Metals doesn't use LSP's file watcher because of the...

> Isn't it a different thing though? I think the notification is send when user deletes it themselves. Ahhh, right, `didDelete` notification is something unrelated to LSP FileWatcher 😅 >...

@PeuTit Yes, that's perfectly what I was thinking about :100: As @tgodzik mentioned, there might be a problem (I hope there's no problem🤞), but let's see ... > We should...

@PeuTit Thank you for taking a look at this! I think re-using `onChange` doesn't work because, first of all, we call `FileIO.slurp` but I guess it will throw an exception...

closing for https://github.com/scalameta/metals/pull/4377

Hi, @strelec thank you for reporting! Which version of Scala are you using, it should be fixed in Scala 3.2.0-RC1 https://github.com/scalameta/metals/issues/3724 so if you're using Scala3.x, could you check it...

So that people can find this issue, let's keep this issue open until 3.2.0 is released :)