wax icon indicating copy to clipboard operation
wax copied to clipboard

Remove Tesla client

Open boydm opened this issue 3 years ago • 3 comments

Hi. I'm looking at wax and noticed at that deps section in mix.exs brings in the tesla web client, but I can't see anywhere in the code where it is used.

Is it a leftover from the past that can be safely removed? I'd rather not have dependencies loaded that aren't actually being used.

Thanks

boydm avatar Jan 06 '22 20:01 boydm

It is used here to retrieve metadata.

tanguilp avatar Jan 25 '22 07:01 tanguilp

@tanguilp as I was setting this up on my side, just noticed that the link provided in the documentation no longer exists.

It seems that they migrated from a V2 of the service to a V3 where they no longer require the API token!

Source: https://fidoalliance.org/metadata/

gdgp avatar Jan 25 '22 17:01 gdgp

Indeed, thanks for the info! I knew about this but last time I checked specification was not available yet. It's now on my todo list :)

tanguilp avatar Jan 25 '22 17:01 tanguilp

Fixed by https://github.com/tanguilp/wax/pull/23

tanguilp avatar Nov 05 '22 10:11 tanguilp