tangram-play icon indicating copy to clipboard operation
tangram-play copied to clipboard

Revise and add in Tangram tutorials

Open kkowalsky opened this issue 9 years ago • 9 comments

@louh proposed to rename "Tutorial" to "Tangram Tutorial", but I think this ties into the overall question of tutorials for Tangram and what we want to do about the former tutorial there. @meetar and I are editing parts of the new tutorials and IMHO we should have "Tangram Tutorial" link to a new tutorial section in the docs (this would be the first completion of the tangram docs cleanup).

kkowalsky avatar Jan 24 '17 17:01 kkowalsky

rename to be 'New to Tangram?' in tangram play

kkowalsky avatar Jan 24 '17 19:01 kkowalsky

okay so it looks like the React error @meetar faced is fixed, so once @rmglennon edits the intro tutorial, we can a few of the new tutorials in?

kkowalsky avatar Jan 25 '17 00:01 kkowalsky

@kkowalsky Was there a fix somewhere? I'm still seeing (what I believe is) the error at https://precog.mapzen.com/mapzen/documentation/meetar/tutorial-divs/documentation/tangram/custom-styles/ – do we need to update something?

meetar avatar Jan 25 '17 16:01 meetar

hmmmm @louh said the react error was solved?

kkowalsky avatar Jan 25 '17 19:01 kkowalsky

sweet! do you have a link to it?

meetar avatar Jan 25 '17 20:01 meetar

Oh, let me clarify! The React error was being thrown because it was attempting to display another error message in an error modal (which is a React component). These modals aren't present in the embedded version of Play, since I've stripped out all non-essential components, so when the app tells React to display the error, there's no component to display it in, so React threw the error.

I've fixed the React issue by making it so errors are no longer dependent on the React component existing, but it doesn't solve the original problem which is that an error message was being thrown somewhere. Now, the errors you see in console should be the original errors, and not the React one.

Some more details about those errors are here: https://github.com/tangrams/tangram-play/issues/628

The problem is while those errors are being thrown in Tangram Play, they seem to indicate a potential nonexistence of supposedly omnipresent global browser objects, which is an existential crisis I've never seen as a browser error before.

louh avatar Jan 25 '17 20:01 louh

For the initial release, let's remove the 'tutorial' button and add them in after redesign of the docs.

kkowalsky avatar Jan 27 '17 01:01 kkowalsky

I think we should remove tutorials completely at the moment because it's never been edited and may not be the best teaching tool for Tangram. It also could be confusing to have 'tutorial' where someone might expect that to be a Tangram Play interface tutorial.

kkowalsky avatar Jan 31 '17 01:01 kkowalsky

OK - I will rename this issue and assign to you to keep an eye on post-launch

louh avatar Jan 31 '17 18:01 louh