tangram-play icon indicating copy to clipboard operation
tangram-play copied to clipboard

don't show widgets on array or code blocs

Open patriciogonzalezvivo opened this issue 9 years ago • 6 comments

patriciogonzalezvivo avatar Oct 21 '15 17:10 patriciogonzalezvivo

@patriciogonzalezvivo Do you remember what this was about?

louh avatar Sep 08 '16 21:09 louh

Yes... prevent widgets to mess with arrays like color: [[15,[0.,0,0]], [20,[1.,1.,1.]]] or JS blocks like color: function() {return [1.,0,0]}

patriciogonzalezvivo avatar Sep 09 '16 11:09 patriciogonzalezvivo

Got it - do we have an idea of how we want to address this? Should a color picker mark never appear if the value string is not actually parseable by the color picker? This is similar to how Chrome's inspector works.

louh avatar Sep 10 '16 15:09 louh

In the first case the ideal would be to create a color picker for each of the inner color values... But that obviously requires a lot more parsing.

For JS functions, makes sense to show nothing I think.

On Saturday, September 10, 2016, Lou Huang [email protected] wrote:

Got it - do we have an idea of how we want to address this? Should a color picker mark never appear if the value string is not actually parseable by the color picker? This is similar to how Chrome's inspector works.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tangrams/tangram-play/issues/211#issuecomment-246118570, or mute the thread https://github.com/notifications/unsubscribe-auth/AABBXeOVtzACzLG1ksn4P-Z-Nz2xuJDTks5qos8-gaJpZM4GTK3s .

bcamper avatar Sep 10 '16 15:09 bcamper

What does it actually mean when a color value is [[15,[0.,0,0]], [20,[1.,1.,1.]]]? Is this documented anywhere?

Also would it be equal to expressing this in YAML's sequence notation?

color:
  -
    - 15
    -
      - 0.
      - 0
      - 0
  -
    - 20
    -
      - 1
      - 1
      - 1

On Sat, Sep 10, 2016 at 11:53 AM Brett Camper [email protected] wrote:

In the first case the ideal would be to create a color picker for each of the inner color values... But that obviously requires a lot more parsing.

For JS functions, makes sense to show nothing I think.

On Saturday, September 10, 2016, Lou Huang [email protected] wrote:

Got it - do we have an idea of how we want to address this? Should a color picker mark never appear if the value string is not actually parseable by the color picker? This is similar to how Chrome's inspector works.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/tangrams/tangram-play/issues/211#issuecomment-246118570 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AABBXeOVtzACzLG1ksn4P-Z-Nz2xuJDTks5qos8-gaJpZM4GTK3s

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tangrams/tangram-play/issues/211#issuecomment-246119297, or mute the thread https://github.com/notifications/unsubscribe-auth/ACb1tHUIO4Jrvhl6H-SHXWqivIrVFzS3ks5qotJqgaJpZM4GTK3s .

louh avatar Sep 10 '16 17:09 louh

It means it has multiple values interpolated by zoom:

https://mapzen.com/documentation/tangram/yaml/#stops

On Saturday, September 10, 2016, Lou Huang [email protected] wrote:

What does it actually mean when a color value is [[15,[0.,0,0]], [20,[1.,1.,1.]]]? Is this documented anywhere?

Also would it be equal to expressing this in YAML's sequence notation?

color:
-
- 15
-
- 0.
- 0
- 0
-
- 20
-
- 1
- 1
- 1

On Sat, Sep 10, 2016 at 11:53 AM Brett Camper <[email protected] javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:

In the first case the ideal would be to create a color picker for each of the inner color values... But that obviously requires a lot more parsing.

For JS functions, makes sense to show nothing I think.

On Saturday, September 10, 2016, Lou Huang <[email protected] javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:

Got it - do we have an idea of how we want to address this? Should a color picker mark never appear if the value string is not actually parseable by the color picker? This is similar to how Chrome's inspector works.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/tangrams/tangram-play/issues/211# issuecomment-246118570 , or mute the thread < https://github.com/notifications/unsubscribe- auth/AABBXeOVtzACzLG1ksn4P-Z-Nz2xuJDTks5qos8-gaJpZM4GTK3s

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/tangrams/tangram-play/issues/211# issuecomment-246119297>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACb1tHUIO4Jrvhl6H- SHXWqivIrVFzS3ks5qotJqgaJpZM4GTK3s> .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tangrams/tangram-play/issues/211#issuecomment-246124035, or mute the thread https://github.com/notifications/unsubscribe-auth/AABBXabABP2O-3F1BOgKhC7p7jCK7jTGks5qoudngaJpZM4GTK3s .

bcamper avatar Sep 10 '16 19:09 bcamper