tangram-es icon indicating copy to clipboard operation
tangram-es copied to clipboard

Published 20 hours ago • verified publisher icon tangrams

Fix label placement loop

Open hjanetzek opened this issue 8 years ago • 5 comments

https://github.com/tangrams/tangram-es/issues/936

hjanetzek avatar Sep 05 '16 18:09 hjanetzek

I was just checking over this and testing the result, but I find myself unable to reproduce the original bug on master now. Is someone else able to confirm that this is still a problem?

matteblair avatar Sep 12 '16 20:09 matteblair

@blair1618 it is super hard to reproduce even when one knows at which labels constellation it has occured. I'll write a test case for it.

hjanetzek avatar Sep 12 '16 21:09 hjanetzek

needs update

hjanetzek avatar Nov 17 '16 16:11 hjanetzek

Hey @hjanetzek we feel like should close this PR. Code has changed a lot already and we have not seen this weird loop issue come up again.

tallytalwar avatar Feb 07 '17 18:02 tallytalwar

I'm fine merging it or not, seems pretty benign.

matteblair avatar Feb 07 '17 19:02 matteblair