tangram-es icon indicating copy to clipboard operation
tangram-es copied to clipboard

Flickering on first zoom out after clearing map data layer

Open westnordost opened this issue 4 years ago • 4 comments

Summary Zooming in and out usually looks smooth. However, if you clear a map data layer while being zoomed in, the first time you zoom out again will lead to flickering of the features in the map data layer that should have been cleared.

It looks as if the features in the map data layer have not been cleared yet on the different zoom levels and are so only when first entering that zoom level. I did not test whether this bug only occurs when clearing a map data layer or also when setting (different) features on it.

Video here: https://www.westnordost.de/misc/tangram-flicker-2133.mp4

Reproduction

  • add a map data layer via MapController.addDataLayer and add a geometry to it
  • Zoom in
  • Clear the map data layer
  • Zoom out. Doesn't matter if manually via gesture or with an animation.

Result The cleared features in the map data layer flicker on zooming out.

Expected result They do not flicker but are gone right away.

Environment Tangram Version 0.11.2 Tested on Android Version 5.1.2 Tested on Sony Xperia Z1 Compact

westnordost avatar Jan 20 '20 12:01 westnordost

Just a clarification: in https://github.com/tangrams/tangram-es/issues/2131 it sounded like this started in version 0.12.0, is that the case?

matteblair avatar Jan 22 '20 05:01 matteblair

No, #2131 existed all-along, at least since 0.9.6 but was fixed in 0.12.0.

This issue turned up on 0.12.0.

On January 22, 2020 6:33:35 AM GMT+01:00, Matt Blair [email protected] wrote:

Just a clarification: in https://github.com/tangrams/tangram-es/issues/2131 it sounded like this started in version 0.12.0, is that the case?

westnordost avatar Jan 22 '20 11:01 westnordost

Seems like a consequence of the changes as part of #2118, possible proxy tiles are holding onto this data. If I understand this correctly, @matteblair I might steal assignee from you.

tallytalwar avatar Jan 24 '20 15:01 tallytalwar

I just want to throw in an example how it looks like, running on Android 9:

https://youtu.be/NYgtkI5tU7U

RubenKelevra avatar Feb 02 '20 14:02 RubenKelevra